Fix source file check for non portable pdb #558
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank's to @adrianhara #524 (comment) I found an issue on new local source file check during instrumentation.
If pdf is not a portable pdb
metadataReaderProvider.GetMetadataReader()
throws exceptionInvalid COR20 header signature.
because we can read only portable pdb.For now in case of exception for this reason we'll skip check so we'll instument module.
Return false would block user and in case of issue we'll can skip bad module with exclusion filter, so I think it's a good solution.
cc: @tonerdo @petli
Thank's a lot Adrian for the repro!
NB: minor change, I fixed redundant verbosity log.
New verbose output