Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mode selecting within combined short arguments. #45

Merged
merged 5 commits into from
Dec 7, 2021
Merged

Conversation

rocketdey
Copy link
Collaborator

Instead of giving mode separately like -e '-Arrp you can now just use -eArrp.

@covert-encryption
Copy link
Owner

Your implementation is already good but see my final comment for a possible simpler implementation.

I hope that you could also add additional tests in test_cli.py for different ways of specifying the mode, and for the different error messages that can occur here if wrong arguments are specified.

Comment on lines -5 to +6
from covert.__main__ import argparse # Import *after* capsys wraps stdout/stderr
from covert.__main__ import argparse

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to remove the extra whitespace on line 6, but why remove the comment?

Comment on lines +33 to +34
# For combined mode
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line between tests.

@covert-encryption covert-encryption merged commit 8030c56 into covert-encryption:main Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants