Allow mode selecting within combined short arguments. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your implementation is already good but see my final comment for a possible simpler implementation. I hope that you could also add additional tests in test_cli.py for different ways of specifying the mode, and for the different error messages that can occur here if wrong arguments are specified. |
Comment on lines
-5
to
+6
| from covert.__main__ import argparse # Import *after* capsys wraps stdout/stderr | ||
| from covert.__main__ import argparse | ||
|
|
There was a problem hiding this comment.
Good to remove the extra whitespace on line 6, but why remove the comment?
Comment on lines
+33
to
+34
| # For combined mode |
There was a problem hiding this comment.
Add an empty line between tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of giving mode separately like
-e '-Arrpyou can now just use-eArrp.