Support editing archives, keeping encrypted notes #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 68.96% 70.85% +1.89%
==========================================
Files 22 22
Lines 2088 2131 +43
Branches 488 499 +11
==========================================
+ Hits 1440 1510 +70
+ Misses 508 485 -23
+ Partials 140 136 -4
Continue to review full report at Codecov.
|
added 5 commits
December 23, 2021 01:13
…< armored` piped decoding that was previously broken.
# Conflicts: # tests/test_cli.py
|
This needs still some additional work on decoding from pipe (an unrelated bug discovered while testing the new feature), but should be essentially usable now. Armor decoding got an optimisation that makes it noticeably faster for large data. As additional benefits on end-to-end testing, we can now use stdio pipes and hashing passwords is much faster. |
added 2 commits
December 23, 2021 14:33
|
Will need to address that FIXME added in another PR prior to 0.6 release. |
rocketdey
approved these changes
Dec 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
covert editCLI command that extracts an existing archive, allows editing its text and then re-encrypts the data. Any attached files of the archive are kept without extracting them or the message to disk. The original file is overwritten.This function is intended to allow adding and removing attachments, as well as using public keys, but for now it is limited to message editing and passphrases. Also, all data must fit in RAM, as no streaming is yet implemented for this mode.
Fixes #57