Being smart about ENOENT won't work on Windows

nodejs/node#8797
cozy-labs · Jul 6, 2017 · 1a15821 · 1a15821
1 parent 117f278
commit 1a15821
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/cli/src/local/index.js b/cli/src/local/index.js
@@ -358,7 +358,6 @@ class Local implements Side {
       this.events.emit('delete-file', doc)
       return
     } catch (err) {
-      if (err.code === 'ENOENT') return
       if (err.code !== 'ENOTEMPTY') throw err
     }
     log.warn({path: doc.path}, 'Folder is not empty!')

diff --git a/cli/test/unit/local/index.js b/cli/test/unit/local/index.js
@@ -680,19 +680,11 @@ describe('Local', function () {
       ])
     })
 
-    it('does not complain when folder was already deleted (ENOENT)', async function () {
+    it('does not swallow fs errors', async function () {
       const doc = builders.dirMetadata().build()
 
       await should(this.local.deleteFolderAsync(doc))
-        .be.fulfilled()
-    })
-
-    it('does not swallow other fs errors', async function () {
-      const doc = builders.dirMetadata().build()
-      await fs.ensureFileAsync(fullPath(doc))
-
-      await should(this.local.deleteFolderAsync(doc))
-        .be.rejectedWith(/ENOTDIR/)
+        .be.rejectedWith(/ENOENT/)
     })
 
     it('throws when given non-folder metadata', async function () {