feat: Migrate storage from AsyncStorage to MMKV #1265
Draft
+185
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
zatteo
reviewed
Dec 20, 2024
| await migrateFromAsyncStorage() | ||
| setHasMigrated(true) | ||
| } catch (e) { | ||
| // TODO: fall back to AsyncStorage? Wipe storage clean and use MMKV? Crash app? |
There was a problem hiding this comment.
TODO ? But don't know what to do...
3 tasks
|
About the second commit message
There are no links with RN73 no? |
Ldoppea
force-pushed
the
feat/add_performance_measurements
branch
from
46a63ec to
9f81a02
Compare
Ldoppea
force-pushed
the
feat/add_performance_measurements
branch
from
9f81a02 to
e76e118
Compare
Ldoppea
force-pushed
the
feat/mmkv
branch
2 times, most recently
from
acd273d to
9215bc8
Compare
Ldoppea
force-pushed
the
feat/add_performance_measurements
branch
from
e76e118 to
9477980
Compare
Ldoppea
force-pushed
the
feat/add_performance_measurements
branch
from
9477980 to
550084c
Compare
Ldoppea
force-pushed
the
feat/add_performance_measurements
branch
from
550084c to
4c6ccc2
Compare
Ldoppea
force-pushed
the
feat/add_performance_measurements
branch
from
4c6ccc2 to
fabbd4e
Compare
Since we migrated the project to RN73 we can now use MMKV instead of AsyncStorage This migration is done in order to improve performances. MMKV being faster by multiple order of magnitude than AsyncStorage Code taken from #1097 Co-authored-by: Théo Poizat <hello@zatteo.com>
Since we migrated to MMKV, existing users' data should be migrated from the old AsyncStorage to MMKV Code taken from #1097 Co-authored-by: Théo Poizat <hello@zatteo.com>
Ldoppea
force-pushed
the
feat/add_performance_measurements
branch
from
fabbd4e to
8821f44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we migrated the project to RN73 we can now use MMKV instead of AsyncStorage
This migration is done in order to improve performances. MMKV being faster by multiple order of magnitude than AsyncStorage
This PR replaces #1097