feat: Implement email login for OIDC accounts #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When entering an email linked to an OIDC Cozy, the received email will open the Manager that will then redirect to OIDC Oauth Previous implementation did not support this scenario When this scenario is detected, then the Manager should redirect to the Authentication screen that will trigger the OAuth process
On IOS we encountered a bug that prevented the InAppBrowser to process the `redirect_after_oidc` redirection if this one is an Universal Link and if the OAuth login happened automatically (i.e. if the user was already logged to the OIDC account) We already handled that for Android in the past, but this seems to be also the case for iOS So like for Android we now use the app's scheme which is correctly handled even if the OAuth dance ends without any user interaction
Ldoppea
force-pushed
the
fix/email_oidc
branch
from
c2f0f49 to
49952c7
Compare
zatteo
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When entering an email linked to an OIDC Cozy, the received email will open the Manager that will then redirect to OIDC Oauth
Previous implementation did not support this scenario
When this scenario is detected, then the Manager should redirect to the Authentication screen that will trigger the OAuth process