fix: Call showOauthClientsLimitExceeded only when Cookie exists #956
Conversation
When showing OauthClientsLimitExceeded we should ensure that a Session Cookie is set on the app If not, the popup will display a cozy-stack error After the login scenario, when cozy-home does its first render, then no Session Cookie exist yet. In that case we should call `getIndexHtmlForSlug` at least once to generate the Session Cookie So in that case we want to call `showOauthClientsLimitExceeded` only after `getIndexHtmlForSlug` But if a Session Cookie exists, then we want to continue doing the check before calling `getIndexHtmlForSlug` so we prevent unnecessary `getIndexHtmlForSlug` calls (this queries cozy-stack) when OauthClientsLimit is exceeded and when the Session Cookie exists
Ldoppea
force-pushed
the
fix/oauth_limit_not_connected
branch
from
29c0108 to
d64f725
Compare
| if (isOauthClientsLimitExeeded) { | ||
| if (slug === 'home') { | ||
| showOauthClientsLimitExceeded(href) | ||
| return false |
There was a problem hiding this comment.
Why do we want to render the home even if oauth clients limit is exceeded ?
There was a problem hiding this comment.
Here the home will be rendered behind the pop so it won't be visible by the user
We do this to improve user experience so when they fix the number of OAuth client, they will instantaneously go to the home (as it is already loaded)
More generally, we try to always have the homeView loaded for this reason (except when no user is logged)
Note that we do this for the HomeView because it has its own container. We cannot do this for cozy-app because one container is used for all cozy-app, so for example we cannot keep drive and mespapiers loaded simultaneously. But if we could we would have done it.
There was a problem hiding this comment.
Thank you for the explanation!
When showing OauthClientsLimitExceeded we should ensure that a Session Cookie is set on the app
If not, the popup will display a cozy-stack error
After the login scenario, when cozy-home does its first render, then no Session Cookie exist yet. In that case we should call
getIndexHtmlForSlugat least once to generate the Session CookieSo in that case we want to call
showOauthClientsLimitExceededonly aftergetIndexHtmlForSlugBut if a Session Cookie exists, then we want to continue doing the check before calling
getIndexHtmlForSlugso we prevent unnecessarygetIndexHtmlForSlugcalls (this queries cozy-stack) when OauthClientsLimit is exceeded and when the Session Cookie exists