Remove OS in new connection emails (#4419)

The OS was guessed from the User-Agent, but the browsers have implemented anti-fingerprinting measures that makes it more confusing than helping for the user. The simpler is to remove it in emails.
cozy · Jun 10, 2024 · 4b28087 · 4b28087
2 parents 26fbb86 + 9eae458
commit 4b28087
Show file tree

Hide file tree

Showing 9 changed files with 930 additions and 952 deletions.
diff --git a/assets/locales/de.po b/assets/locales/de.po
@@ -715,9 +715,6 @@ msgstr "IP Adresse:"
 msgid "Mail New Connection Browser"
 msgstr "Browser:"
 
-msgid "Mail New Connection OS"
-msgstr "Gerät:"
-
 msgid "Mail New Connection Change Passphrase instruction"
 msgstr ""
 "Wenn du hinter dieser neuen Verbindung steckst, kannst du diese Nachricht ignorieren und dein Cozy genießen.\n"

diff --git a/assets/locales/en.po b/assets/locales/en.po
@@ -969,9 +969,6 @@ msgstr "IP Address:"
 msgid "Mail New Connection Browser"
 msgstr "Browser:"
 
-msgid "Mail New Connection OS"
-msgstr "Device:"
-
 msgid "Mail New Connection Change Passphrase instruction"
 msgstr ""
 "If you are behind this new connection, you can ignore this message and enjoy your Cozy.\n"

diff --git a/assets/locales/es.po b/assets/locales/es.po
@@ -717,9 +717,6 @@ msgstr "Dirección IP:"
 msgid "Mail New Connection Browser"
 msgstr "Navegador:"
 
-msgid "Mail New Connection OS"
-msgstr "Dispositivo:"
-
 msgid "Mail New Connection Change Passphrase instruction"
 msgstr ""
 "Si está detrás de esta nueva conexión, puede ignorar este mensaje y disfrutar de su Cozy.\n"

diff --git a/assets/locales/fr.po b/assets/locales/fr.po
@@ -1065,9 +1065,6 @@ msgstr "Adresse IP :"
 msgid "Mail New Connection Browser"
 msgstr "Navigateur :"
 
-msgid "Mail New Connection OS"
-msgstr "Appareil :"
-
 msgid "Mail New Connection Change Passphrase instruction"
 msgstr ""
 "Vous confirmez en être l’initiateur ? Si oui, profitez de ce nouvel accès !\n"

diff --git a/assets/locales/ja.po b/assets/locales/ja.po
@@ -580,9 +580,6 @@ msgstr "IP アドレス"
 msgid "Mail New Connection Browser"
 msgstr "ブラウザー"
 
-msgid "Mail New Connection OS"
-msgstr "オペレーティングシステム"
-
 msgid "Mail New Connection Change Passphrase instruction"
 msgstr ""
 "あなたが行いましたか? すばらしいです! 安心しました。 ご不便おかけしてすみません。 "

diff --git a/assets/locales/nl_NL.po b/assets/locales/nl_NL.po
@@ -902,9 +902,6 @@ msgstr "IP-adres:"
 msgid "Mail New Connection Browser"
 msgstr "Webbrowser:"
 
-msgid "Mail New Connection OS"
-msgstr "Apparaat:"
-
 msgid "Mail New Connection Change Passphrase instruction"
 msgstr ""
 "Was je dit zelf? Dan kun je dit bericht negeren.\n"

diff --git a/assets/mails/new_connection.mjml b/assets/mails/new_connection.mjml
@@ -11,7 +11,6 @@
 		<li>{{t "Mail New Connection Place"}} {{.Country}}</li>
 		<li>{{t "Mail New Connection Time"}} {{.Time}}</li>
 		<li>{{t "Mail New Connection Browser"}} {{.Browser}}</li>
-		<li>{{t "Mail New Connection OS"}} {{.OS}}</li>
 		<li>{{t "Mail New Connection IP"}} {{.IP}}</li>
 	</ul>
 </mj-text>

diff --git a/model/session/login_history.go b/model/session/login_history.go
@@ -221,7 +221,6 @@ func sendLoginNotification(i *instance.Instance, l *LoginEntry) error {
 		"Country":              l.Country,
 		"IP":                   l.IP,
 		"Browser":              l.Browser,
-		"OS":                   l.OS,
 		"ChangePassphraseLink": changePassphraseLink,
 		"ActivateTwoFALink":    activateTwoFALink,
 	}

diff --git a/web/statik/statik.go b/web/statik/statik.go