Fix weird behaviours for NextCloud/WebDAV #4407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
approved these changes
May 23, 2024
|
This PR does not fix the issue though. |
When the userId contains a space, the base path for webdav can be incorrectly matched in the xml response for PROPFIND, and the parent directory is no longer excluded. The fix is to encode sooner the base path.
nono
force-pushed
the
fix-nextcloud-userid
branch
from
71dc153
to
9c4472c
Compare
|
@taratatach can you try again? |
|
It looks like the bug has been fixed without this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the userId contains a space, the base path for webdav can be incorrectly matched in the xml response for PROPFIND, and the parent directory is no longer excluded. The fix is to encode sooner the base path.