Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the stack runnable from default config #4445

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Make the stack runnable from default config #4445

merged 1 commit into from
Jul 16, 2024

Conversation

paultranvan
Copy link
Contributor

When running the stack after copying the default configuration file, the stack won't start because of errors due to fake paths defined for firebase and encryption.
Let's comment them to ease incoming developers' life.

When running the stack after copying the default configuration file,
the stack won't start because of errors due to fake paths defined
for firebase and encryption.
Let's comment them to ease incoming developers' life.
@paultranvan paultranvan requested a review from a team as a code owner July 16, 2024 07:09
Copy link
Member

@nono nono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think that developers should start from a blank file and just add what they need to their configuration file, but, well, in practice, it doesn't seem that developers do that...

@paultranvan
Copy link
Contributor Author

in practice, it doesn't seem that developers do that...

I can confirm, I witnessed it many times. People tend to prefer a ready-to-work conf file and eventually adapt if required

@paultranvan paultranvan merged commit 55c3dd8 into master Jul 16, 2024
3 checks passed
@paultranvan paultranvan deleted the conf-file branch July 16, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants