-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make list_agents
paginated
#1525
Open
cpacker
wants to merge
11
commits into
main
Choose a base branch
from
get-agents-cursor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpacker
commented
Jul 8, 2024
…metadata stores on update_state/agent.step
sarahwooders
requested changes
Jul 12, 2024
memgpt/server/server.py
Outdated
# - last run data | ||
# - memory stats (recall, archival) | ||
# - number of sources | ||
return [agentstate_to_agentstatemodel(a_s) for a_s in agents_states] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to do the conversion in the REST API, since if you just return List[AgentState]
then the LocalClient
can directly use this
…T, move them to separate rest routes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1498
Change in API endpoint
GET request is now paginated, in the style of: https://platform.openai.com/docs/api-reference/assistants/listAssistants
Change in data locations
For @goetzrobin: there's some differences in the data coming back from the GET request (apart from it now accepting additional pagination args):
MemGPT/memgpt/server/server.py
Line 864 in 82ae5a2
"persona" / "human"
This should still be accessible in the
List[AgentStateModel]
being returned"tools"
This is now inAgentStateModel.metadata["tools"]
NOTE: this has been moved to a separate
GET
request: see new routedef get_agent_tools
(router.get("/agents/{agent_id}/tools
)"memory stats"
This is now in
AgentStateModel.metadata["memory_stats"]
, see newAgent.update_state
function"last run"
This is now in
AgentStateModel.metadata["last_run"]
"attached sources"
This is now inAgentStateModel.metadata["sources"]
NOTE: this has been moved to a separate
GET
request:def get_agent_sources
(/agents/{agent_id}/sources
)^extra note @goetzrobin these metadata fields may be
null
for old agents, since they are stored inside ofmetadata
they will get refreshed on.step()
, so only agents that have been run post-PR will have the metadata fields. The frontend should have sane defaults / not crash on null accordingly.