Skip to content

Commit

Permalink
options: update --bare help message
Browse files Browse the repository at this point in the history
The current `--bare` help message is a little bit confusing: It says
that it will not work with `--tags` properly, but in fact, I would
assume it means that it may not work properly instead.

With `--bare`, the name will be `${KO_DOCKER_REPO}:<tag>`.
  • Loading branch information
zhouhaibing089 committed Feb 19, 2021
1 parent 8e1aaa1 commit b27ed4e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/commands/options/publish.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ type PublishOptions struct {
PreserveImportPaths bool
// BaseImportPaths uses the base path without MD5 hash after KO_DOCKER_REPO.
BaseImportPaths bool
// Base uses a tag on the KO_DOCKER_REPO without anything additional.
// Bare uses a tag on the KO_DOCKER_REPO without anything additional.
Bare bool
}

Expand All @@ -65,7 +65,7 @@ func AddPublishArg(cmd *cobra.Command, po *PublishOptions) {
cmd.Flags().BoolVarP(&po.BaseImportPaths, "base-import-paths", "B", po.BaseImportPaths,
"Whether to use the base path without MD5 hash after KO_DOCKER_REPO (may not work properly with --tags).")
cmd.Flags().BoolVar(&po.Bare, "bare", po.Bare,
"Whether to just use KO_DOCKER_REPO without additional context (will not work properly with --tags).")
"Whether to just use KO_DOCKER_REPO without additional context (may not work properly with --tags).")
}

func packageWithMD5(base, importpath string) string {
Expand Down

0 comments on commit b27ed4e

Please sign in to comment.