Merge blockers into components #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cPholloway
force-pushed
the
RE-673
branch
4 times, most recently
from
8bf8234
to
9e6e361
Compare
cPholloway
requested review from
toddr,
timmullin,
sloanebernstein,
troglodyne and
msalinas90
lib/Elevate/Components/AutoSSL.pm
Outdated
| WARN( <<~"EOS" ); | ||
| Elevating with Sectigo as the provider for AutoSSL is not supported. | ||
| If you proceed with this upgrade, we will switch your system | ||
| to use the Let's Encrypt�~D� provider. |
There was a problem hiding this comment.
UTF-8 mojibake
Since we pretty much force the C locale, maybe replace the screwed up ® or ™ with (R) or (TM)?
cPholloway
force-pushed
the
RE-673
branch
2 times, most recently
from
84f17e4
to
32e2c75
Compare
Case RE-673: This is a refactor to merge Blockers into Components so that they share a common base. It also enforces that each Component provides a check, pre_distro_upgrade, and post_distro_upgrade method (even if they are noops). Changelog: Merge blockers into components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case RE-673: This is a refactor to merge Blockers into Components so that they share a common base. It also enforces that each Component provides a check, pre_distro_upgrade, and post_distro_upgrade method (even if they are noops).
Changelog: Merge blockers into components
By submitting pull requests to this repo, I agree to the Contributor License Agreement which can be found at: https://github.com/cpanel/elevate/blob/main/docs/cPanel-CLA.pdf