Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add equality method to PathSpec #13

Merged
merged 2 commits into from
Apr 5, 2017
Merged

Add equality method to PathSpec #13

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e8b022
Add equality method to PathSpec
ghickman Mar 27, 2017
8cdc7cf
Use izip_longest to avoid false positive
ghickman Mar 28, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions pathspec/pathspec.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@ def __init__(self, patterns):
"""

self.patterns = patterns if isinstance(patterns, collections.Container) else list(patterns)

def __eq__(self, other):
"""
Tests equality of this ``PathSpec`` with ``other`` based on the
regexs contained in their ``patterns``.
"""
paired_patterns = zip(self.patterns, other.patterns)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might need to use zip_longest() here to avoid equality when one is a "prefix" of the other.

return all(a.regex == b.regex for a, b in paired_patterns)

def __len__(self):
"""
Expand Down