-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: edit error/warning messages color of message logger #1247
Conversation
Add two new settings: "Error Message Color" and "Warn Message Color". These settings are located at Appeareance -> General, and have a combo box to select the colors, using default Qt Colors names (see https://doc.qt.io/qt-5/stylesheet-reference.html#color). Addresses the issue cpeditor#521
Use the settings "Error Message Color" and "Warn Message Color" to retrieve the error/warning colors instead of using hardcoded ones. Addresses issue cpeditor#521
Everything looks good!
|
Add to changelog the option to choose the error/warning message color of message logger.
Update the translation files to address the texts of the two new settings "Error Message Color" and "Warn Message Color"
About the contrast of text color and background, I've tested all the combinations, and most of them looks good to me, except for ones like dark text on dark background or white text on white background. The combinations that don't look good to me are: For white background: lime, aqua, silver, yellow, white text color. |
The documentation pull request will be made soon. And about the mac os one, I will look into it in the near future (after docs). |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
#1268 should unblock this PR, @brun0-matheus please rebase the changes on top of master. EDIT: Done |
@all-contributors please add @brun0-matheus for code |
I've put up a pull request to add @brun0-matheus! 🎉 |
feat: Add option to choose error/warning message colors of message logger
Description
Add two new settings: "Error Message Color" and "Warn Message Color".
These settings are located at Appearance -> General, and have a combo box to select the colors, using default Qt Colors names.
Message Logger code was modified to use these settings instead of hardcoded values.
Related Issues / Pull Requests
Closes #521
Motivation and Context
Some users don't like the default colors for various reasons, so, an option to change them was added.
How Has This Been Tested?
Tested on Fedora Workstation 37, on dark and light modes.
Screenshots (if appropriate)
Checklist
old
attribute is updated or it is resolved in SettingsUpdater.tr()
orQCoreApplication::translate()
.Additional text
It's necessary to translate the settings description and also add in the documentation and changelog.