Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] overwrite files when renaming by default #1051

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

Remi-Gau
Copy link
Contributor

closes #1045

@Remi-Gau Remi-Gau marked this pull request as ready for review June 18, 2023 23:21
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.83%. Comparing base (7d52979) to head (d1062d9).
Report is 187 commits behind head on main.

Files with missing lines Patch % Lines
src/workflows/preproc/bidsCreateVDM.m 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
- Coverage   79.95%   79.83%   -0.12%     
==========================================
  Files         244      245       +1     
  Lines        6655     6661       +6     
  Branches       40       40              
==========================================
- Hits         5321     5318       -3     
- Misses       1318     1327       +9     
  Partials       16       16              
Flag Coverage Δ
cli 38.99% <ø> (ø)
macos-latest_matlab-R2022b 81.19% <83.33%> (-0.03%) ⬇️
octave 77.10% <83.33%> (-0.03%) ⬇️
ubuntu-latest_matlab-R2022b ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau merged commit 1673401 into cpp-lln-lab:main Jun 19, 2023
@Remi-Gau Remi-Gau deleted the rename branch June 19, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Rename does not happen if re-running a step without deleting previous resutls
1 participant