Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add elapsedTime function #229

Merged
merged 7 commits into from
Dec 22, 2021

Conversation

marcobarilari
Copy link
Collaborator

No description provided.

@marcobarilari marcobarilari self-assigned this Dec 13, 2020
@marcobarilari marcobarilari added enhancement New feature or request good first issue Good for newcomers labels Dec 13, 2020
@marcobarilari marcobarilari linked an issue Dec 13, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 13, 2020

Codecov Report

Merging #229 (19d5d9f) into dev (3e28dc1) will increase coverage by 23.18%.
The diff coverage is 100.00%.

❗ Current head 19d5d9f differs from pull request most recent head 9808c15. Consider uploading reports for the commit 9808c15 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #229       +/-   ##
===========================================
+ Coverage   46.29%   69.47%   +23.18%     
===========================================
  Files          98      159       +61     
  Lines        1754     3122     +1368     
===========================================
+ Hits          812     2169     +1357     
- Misses        942      953       +11     
Flag Coverage Δ
unittests 69.47% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/elapsedTime.m 100.00% <100.00%> (ø)
src/workflows/cleanUpWorkflow.m 100.00% <100.00%> (ø)
src/workflows/setUpWorkflow.m 100.00% <100.00%> (+100.00%) ⬆️
src/utils/createDataDictionary.m 0.00% <0.00%> (-100.00%) ⬇️
src/utils/printCredits.m 20.00% <0.00%> (-80.00%) ⬇️
src/utils/getEnvInfo.m 27.50% <0.00%> (-54.86%) ⬇️
src/utils/validationInputFile.m 70.58% <0.00%> (-29.42%) ⬇️
src/utils/checkDependencies.m 63.63% <0.00%> (-17.32%) ⬇️
src/subject_level/getBoldFilenameForFFX.m 84.00% <0.00%> (-16.00%) ⬇️
src/subject_level/getFFXdir.m 88.88% <0.00%> (-11.12%) ⬇️
... and 175 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e28dc1...9808c15. Read the comment docs.

@marcobarilari
Copy link
Collaborator Author

what you see so far here is just a trial to see how tic/tic behaves inside a function

@Remi-Gau Remi-Gau force-pushed the marco_add-elapsedTime branch from 92c82a4 to 19d5d9f Compare December 22, 2021 16:13
@Remi-Gau Remi-Gau force-pushed the marco_add-elapsedTime branch from 2897c12 to 6dfc1b9 Compare December 22, 2021 16:17
@Remi-Gau Remi-Gau marked this pull request as ready for review December 22, 2021 16:20
@Remi-Gau
Copy link
Contributor

definitely our longest opened PR so far.

merging this and will refactor and integrate into another PR after that.

@Remi-Gau Remi-Gau merged commit 0c69ca0 into cpp-lln-lab:dev Dec 22, 2021
@marcobarilari marcobarilari deleted the marco_add-elapsedTime branch February 8, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] add print timestap of 'elapsed time' to each workflow
2 participants