Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare HUNTER_GATE_SHA1 after TOLOWER #11

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Conversation

NeroBurner
Copy link

@NeroBurner NeroBurner commented Dec 9, 2020

Don't depend on sha1sum being created with the same capitalization in HunterGate.
Do it the same way as in hunter_make_directory [1], which converts all alphabetical
character to lower-case before comparing the sha1-strings.

[1] https://github.com/cpp-pm/hunter/blob/3b5ce35e418840e080cf6c68accadd70ea31fb58/cmake/modules/hunter_make_directory.cmake#L29

edit: reason for this PR: on Windows the SHA1 sum suddenly didn't compare right anymore because capitalization was different between generated sha1 sum and user provided sha1

Don't depend on sha1sum being created with the same capitalization in HunterGate.
Do it the same way as in `hunter_make_directory`, which converts all alphabetical
character to lower-case before comparing the sha1-strings.
@NeroBurner
Copy link
Author

@rbsheth ping

@rbsheth rbsheth merged commit b7529fb into master Dec 15, 2020
@rbsheth rbsheth deleted the gate_compare_sha1_lower branch December 15, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants