-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Boost to 1.71.0 #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please look into why AppVeyor is failing? The configuration should be very similar to the 1.70.0 release.
Concerning the failed builds on AppVeyor, How ever the PR for 1.69.0-p1 by @Bjoe did already disable the 2 configs that failed here. |
6718c55
to
93272cb
Compare
From here https://github.com/cpp-pm/hunter-testing/blob/pkg.boost/appveyor.yml, I think you’re right - it looks like the three windows toolchains failing is expected. But also looking at that build matrix (which came from ingenue/hunter), it looks like they normally test a bunch of the sub packages in CI as well. Should we be doing that (and same for Travis)? |
Yes, for now I think it makes sens to stick to the same way. Still if I find the time, I'll try looking into it why they break. |
If nmake/ninja/msys didn't work before, I say push this now and fix later. You can always make a revision to the scheme which fixes a bug such as this in a separate commit. It would likely fix all previous versions too. |
I’m okay with not fixing the three windows toolchains as they were failing before. I’m merely suggesting that for boost specifically, we should test all the sub components as well, as that is what was previously done |
93272cb
to
c32dcc3
Compare
c32dcc3
to
42c1bb4
Compare
Sry got caught up in other stuff. I Updated the requested version string from builds running: |
So all test pass with all sub components. But still would be nice if the broken jobs are fixed in the future. What I don't understand is why the appveyor build for this PR breaks. Maybe because the appveyor project was not setup when I created this PR? |
Don’t worry about the builds that we’re already broken. And the appveyor on this repo isn’t set up correctly yet - it’s there for some work I’m doing to improve CI, but it’s not ready yet. |
I've followed this guide
step by step carefully. YES
I've tested this package remotely and have excluded all broken builds. NO
Here is the links to the Travis/AppVeyor with:
The boost package https://github.com/cpp-pm/boost/tree/hunter-1.71.0 was created by using the following script https://gist.github.com/dan-42/ef7ac7306dcde31efa97d66a227baf3e