Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL: replace HUNTER_UWP_PLATFORM with CMAKE_SYSTEM_NAME check #635

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

Dargun
Copy link

@Dargun Dargun commented Nov 3, 2022

replace HUNTER_UWP_PLATFORM with CMAKE_SYSTEM_NAME to follow cmake style

  • I've followed this guide
    step by step carefully. [Yes|No]
  • My change will allow compile OPENSSL for windows universal platforms

  • I've followed this guide
    step by step carefully. [Yes|

  • I've checked this Git style guide. [Yes|No]
  • I've checked this CMake style guide. [Yes|No]
  • My change will work with CMake 3.2 (minimum requirement for Hunter). [Yes|No]
  • I will try to keep this pull request as small as possible and will try not to mix unrelated features. [Yes|No]

…irect openssl uwp config from cmake and polly settings
Copy link

@NeroBurner NeroBurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. This is the only place where HUNTER_UWP_PLATFORM is used in the codebase. Good thing we move to a more CMake-standard way, thanks a lot

@NeroBurner
Copy link

just for future reference WindowsStore is in the official cross compilation documentation in the cmake docs: https://cmake.org/cmake/help/latest/manual/cmake-toolchains.7.html#cross-compiling-for-windows-store

@NeroBurner NeroBurner merged commit 16491e6 into cpp-pm:master Nov 3, 2022
@NeroBurner NeroBurner changed the title replace HUNTER_UWP_PLATFORM with direct CMAKE_SYSTEM_NAME check for d… OpenSSL: replace HUNTER_UWP_PLATFORM with CMAKE_SYSTEM_NAME check Nov 3, 2022
@Dargun Dargun deleted the replace_hunter_uwp_var branch November 3, 2022 19:19
@NeroBurner
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants