Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceres-solver: update to v2.1.0-p0 with OpenBLAS support #643

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

NeroBurner
Copy link

Update ceres-solver to v2.1.0-p0.

Add option WITH_OPENBLAS (disabled in Hunter per default) to build against OpenBLAS instead of generic LAPACK.

OpenBLAS v0.3.21 provides a f2c-converted LAPACK v3.9.0 copy, which is used when building without a Fortran compiler. This enables us to have a C++ only build, making static libraries easier (no fortran runtime libs anymore).

  • I've followed this guide
    step by step carefully. [Yes]

@NeroBurner NeroBurner added the package:update Add a new version to an existing package label Dec 7, 2022
@NeroBurner NeroBurner force-pushed the ceres_solver_2.1.0-p0 branch from 97124f6 to a5c89c8 Compare December 12, 2022 14:14
@NeroBurner
Copy link
Author

updated ceres-solver hunter fork to use the latest https://github.com/cpp-pm/hunter/releases/tag/v0.24.10 release

also snuck in a fix for the SuiteSparse test matrix. Added the cmake args to the wrong project previously. Now fixed

@NeroBurner NeroBurner requested a review from rbsheth December 12, 2022 14:15
Update `ceres-solver` to `v2.1.0-p0`.

Add option `WITH_OPENBLAS` (disabled in Hunter per default) to build
against `OpenBLAS` instead of generic `LAPACK`.

`OpenBLAS` `v0.3.21` provides a f2c-converted `LAPACK` `v3.9.0` copy,
which is used when building without a Fortran compiler.
This enables us to have a C++ only build, making static libraries
easier (no fortran runtime libs anymore).

Update dynLAPACK example with the new OpenBLAS settings (for SuiteSparse
as well).
@NeroBurner NeroBurner force-pushed the ceres_solver_2.1.0-p0 branch from a5c89c8 to 8aa01dc Compare December 12, 2022 14:43
@NeroBurner
Copy link
Author

fixed the Fortran spell checking error in the docs, now should be ready

@NeroBurner NeroBurner merged commit 0042dd2 into master Dec 14, 2022
@NeroBurner NeroBurner deleted the ceres_solver_2.1.0-p0 branch December 14, 2022 20:20
@NeroBurner
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:update Add a new version to an existing package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants