hunter_setup_msvc: tolower to fix arm64 vs ARM64 confusion #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`HUNTER_MSVC_ARCH` should match the capitalization of the `vcvarsall.bat <arch>` argument. The arch argument according to `vcvarsall.bat /help` can be one of the following: ``` [arch]: x86 | amd64 | x86_amd64 | x86_arm | x86_arm64 | amd64_x86 | amd64_arm | amd64_arm64 ``` But to be more like `vcvarsall.at` and `cmake -A`, be case-insensitive with the input architectures. And for less confusion, always output the `HUNTER_ARCH` variables in lower case. In the process cleanup, fix and extend the corresponding unittest. Fixes: #679
Add a special toolchain `hunter_tests` whith a simple build script `build_hunter_tests.sh` to run the Hunter Unittests on an ubuntu runner. All the unittests are run if one of the following folder has a modification: - `cmake/modules/*` - `cmake/schemes/*` - `cmake/templates/*` - `tests/**/*` Fixes: #680
NeroBurner
force-pushed
the
hunter_setup_msvc_ARM64_fix
branch
from
cabdb25 to
5f7db13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HUNTER_MSVC_ARCHshould match the capitalization of thevcvarsall.bat <arch>argument. The arch argument according tovcvarsall.bat /helpcan be one of the following:But to be more like
vcvarsall.atandcmake -A, be case-insensitive with the input architectures.And for less confusion, always output the
HUNTER_ARCHvariables in lower case.In the process cleanup, fix and extend the corresponding unittest.
Fixes: #679