Update fmt package to 9.1.0 #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apivovarov
force-pushed
the
master
branch
2 times, most recently
from
6249a3f to
962c5e8
Compare
|
@erickguan Can you look at |
|
|
|
Looks like it isn't working for some reason. Else things look good. |
|
@apivovarov Sorry for being late. Solid reasoning and comment. Well done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
step by step carefully. [Yes]
I used prev PR-514 as an example
Testing
Tested new
fmt-9.1.0with existingspdlog-1.9.2-p0in one project - everything is OK.