Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove u128 x64 intrinsic pessimzations #725

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Remove u128 x64 intrinsic pessimzations #725

merged 1 commit into from
Sep 19, 2024

Conversation

mborland
Copy link
Member

I never bench-marked these properly and they do in fact make things slightly worse so best if they are removed.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.2%. Comparing base (89e1dd0) to head (c995e23).
Report is 5 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop    #725     +/-   ##
=========================================
+ Coverage     99.1%   99.2%   +0.1%     
=========================================
  Files          229     224      -5     
  Lines        16430   16375     -55     
  Branches      1781    1778      -3     
=========================================
- Hits         16276   16233     -43     
+ Misses         154     142     -12     
Files with missing lines Coverage Δ
include/boost/decimal/detail/emulated128.hpp 97.6% <100.0%> (-<0.1%) ⬇️

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e1dd0...c995e23. Read the comment docs.

@mborland mborland merged commit 7fe2e8f into develop Sep 19, 2024
65 checks passed
@mborland mborland deleted the 128 branch September 19, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant