-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trailing newline in code blocks #113
Conversation
a74886b
to
d87a980
Compare
md2man/roff_test.go
Outdated
".nh\n\n.EX\necho foo\n\n.EE\n", | ||
".nh\n\n.EX\necho foo\n.EE\n", | ||
|
||
// make sure we litteral new lines surrounding in the markdown block are preserved as they are intentional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/we litteral/the literal/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
Overall LGTM, but let me try that on some more inputs first. |
d87a980
to
d3d5f33
Compare
Hi! Thank you very much for this module. I'd like to ask when this PR will be merged? |
d3d5f33
to
4ab80e5
Compare
Given this input: > ``` > some code > ``` We were adding an additional newline character before the code close tag even though the code block by definition already includes that newline. e.g., blackfriday is hadning us `some code\n` as the literal content of the code block. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
4ab80e5
to
fd6bc09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
v2.0.4 includes this fix. |
Given this input:
We were adding an additional newline character before the code close tag even though the code block by definition already includes that newline.
e.g., blackfriday is hadning us
some code\n
as the literal content of the code block.fixes #47