refactor: inline colour picker

[Shobhit-Nagpal]

Changes

• Replaced <PopoverPicker> with <SwatchPicker>
• Passing in setColour as the onChange callback, which is already being debounced inside <SwatchPicker>

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cpvalente]

Nice and straight to the point. I believe we need to make some small changes to improve the feature UX

• could we show the selected colour on the background of the InlineColourPicker element
• could we show the colour code in the input field of the SwatchPicker
• the input and the colour picker seem to be out of sync (see screenshot), can this be improved?

[Shobhit-Nagpal]

could we show the selected colour on the background of the InlineColourPicker element
could we show the colour code in the input field of the SwatchPicker
the input and the colour picker seem to be out of sync (see screenshot), can this be improved?

I'll work on this and let you know

[Shobhit-Nagpal]

hey.

firstly, a very happy new year to you :))

secondly, found the issue for the 3 points that was mentioned. Needed to add another prop to handle the way we were passing in the color from <SwatchPicker> to <PopoverPicker>

pushing the recent changes, let me know if you'd like any other changes. attaching a video to show the working

ontime-pr-2-update-1-2025-01-02_17.42.21.mp4

[cpvalente]

Nice, really good, thank you for your contribution!

If you are willing to continue contributing, I would like to find you something a bit more involved.
Can you help me understand what is your preferred task setup? Do you like to work fullstack? Do you prefer react tasks? Do you like working with technical or performance tasks?

Either way, thank you again and happy new year!

EDIT: I saw that the border radius of the elements inside the popover did not match the popover so i thought I would fix it
I didnt really manage and decided it was not worth sinking too much work on this, but made some changes that you are welcome to comment on. #1420
Hope this is OK with you and that you dont feel I am redoing your work

[Shobhit-Nagpal]

Hope this is OK with you and that you dont feel I am redoing your work

i don't feel that way at all. i'm glad to know that there were improvements that were possible. i believe the product should have the best code possible. super glad i could contribute in the first place

If you are willing to continue contributing, I would like to find you something a bit more involved.
Can you help me understand what is your preferred task setup? Do you like to work fullstack? Do you prefer react tasks? Do you like working with technical or performance tasks?

i'd love to continue. i've wanted to work on performance tasks for quite a while, other than that i like to work fullstack as well. so i'd be good with any of the tasks. meanwhile i'll understand the codebase better on my end

[cpvalente]

meanwhile i'll understand the codebase

Do you use discord? if so, maybe hop into discord server and find me as cv_ and we can find something together

Otherwise, I had in mind something slightly more complex but with little domain requirements (all of these are UI only)

• Add drag and drop to reorder in cuesheet
• create popout clock feature (based on this test PR)
• play sound on time end (based on this test PR)

If you want to continue contributing in long term (with no obligation). I can also add you to the contributors list to simplify the git flow

[Shobhit-Nagpal]

Do you use discord? if so, maybe hop into discord server and find me as cv_ and we can find something together

just joined the server. i think we're already in dms.

If you want to continue contributing in long term (with no obligation). I can also add you to the contributors list to simplify the git flow

i'd like to keep contributing, i think it'd be better if we continue with the current flow. i feel i should know more things and once i'm much more familiar with the codebase and some newer concepts, if it extends to long term, would love to be added to the list