[#227] update installation info #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqfn#228: Update copyright info and actions versions
php-coder
reviewed
Jan 16, 2024
|
|
||
| **For \*nix** | ||
| ```bash | ||
| $ apt install libmagic-dev |
There was a problem hiding this comment.
Strictly speaking, this applies only to Debian/Ubuntu/ALT Linux because other distros don't use apt. Perhaps, it's better to explicitly specify these distros?
php-coder
reviewed
Jan 16, 2024
README.md
Outdated
| @@ -217,13 +248,13 @@ Make sure your build is green before you contribute | |||
| your pull request. You will need to have [Ruby](https://www.ruby-lang.org/en/) 2.3+ and | |||
There was a problem hiding this comment.
Should we raise a minimum Ruby version here as well?
Suggested change
| your pull request. You will need to have [Ruby](https://www.ruby-lang.org/en/) 2.3+ and | |
| your pull request. You will need to have [Ruby](https://www.ruby-lang.org/en/) 2.7+ and |
There was a problem hiding this comment.
Default version on MacOs is 2.6 and it doesn't work on it, it was required to install upper one
php-coder
reviewed
Jan 16, 2024
|
|
||
| #### Ruby version 2.7+ | ||
| </summary> | ||
| [Ruby installation instruction](https://www.ruby-lang.org/en/documentation/installation/) |
There was a problem hiding this comment.
I see that at https://github.com/pnatashap/pdd/tree/227 this link wasn't rendered properly.
php-coder
reviewed
Jan 17, 2024
Co-authored-by: Slava Semushin <slava.semushin@gmail.com>
|
All the content available in #231 also (just to avoid questions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add installation part with Ruby (and minimum version) and Libmagic