Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure a CQL expression referencing an abstract class/non-retrievable class, such as DomainResource, will fail. #1404

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

lukedegruchy
Copy link
Contributor

  • Update all ModelInfo XMLs to mark DomainResource as retrievable false
  • Add a new test to ensure that an expression referencing DomainResource will fail with an expected error that the class is not retrievable

Closes #1392

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.74%. Comparing base (c074fae) to head (62aedf4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1404   +/-   ##
=========================================
  Coverage     63.74%   63.74%           
  Complexity     2666     2666           
=========================================
  Files           493      493           
  Lines         27782    27782           
  Branches       5523     5523           
=========================================
+ Hits          17709    17711    +2     
+ Misses         7830     7828    -2     
  Partials       2243     2243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival merged commit 100ebe3 into master Aug 26, 2024
5 checks passed
@JPercival JPercival deleted the 1392-abstract-class-retrieveable-false branch August 26, 2024 15:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieval of DomainResource should warn/error
3 participants