-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use conditional logic to select the error message for an unmatched identifier based on whether it was a case-insensitive match #1406
Merged
lukedegruchy
merged 9 commits into
master
from
598-non-resolved-case-mismatch-warning-2
Aug 30, 2024
Merged
Use conditional logic to select the error message for an unmatched identifier based on whether it was a case-insensitive match #1406
lukedegruchy
merged 9 commits into
master
from
598-non-resolved-case-mismatch-warning-2
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting check succeeded! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1406 +/- ##
============================================
- Coverage 63.74% 63.73% -0.02%
Complexity 2666 2666
============================================
Files 493 494 +1
Lines 27782 27834 +52
Branches 5523 5527 +4
============================================
+ Hits 17711 17741 +30
- Misses 7828 7850 +22
Partials 2243 2243 ☔ View full report in Codecov by Sentry. |
…the error message should be based on whether it's due to a case insensitive match.
lukedegruchy
changed the title
Copy changes in 598-non-resolved-case-mismatch-warning into a fresh b…
Use conditional logic to select the error message for an unmatched identifier based on whether it was a case-insensitive match
Aug 27, 2024
brynrhodes
approved these changes
Aug 29, 2024
Capt-Mac
approved these changes
Aug 30, 2024
JPercival
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #598