Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use conditional logic to select the error message for an unmatched identifier based on whether it was a case-insensitive match #1406

Merged
merged 9 commits into from
Aug 30, 2024

Conversation

lukedegruchy
Copy link
Contributor

@lukedegruchy lukedegruchy commented Aug 27, 2024

Closes #598

Copy link

github-actions bot commented Aug 27, 2024

Formatting check succeeded!

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 64.32432% with 66 lines in your changes missing coverage. Please review.

Project coverage is 63.73%. Comparing base (100ebe3) to head (8cd2d2e).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...va/org/cqframework/cql/cql2elm/LibraryBuilder.java 71.17% 23 Missing and 9 partials ⚠️
...k/cql/cql2elm/model/ResolvedIdentifierContext.java 41.81% 30 Missing and 2 partials ⚠️
...cqframework/cql/cql2elm/model/CompiledLibrary.java 89.47% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1406      +/-   ##
============================================
- Coverage     63.74%   63.73%   -0.02%     
  Complexity     2666     2666              
============================================
  Files           493      494       +1     
  Lines         27782    27834      +52     
  Branches       5523     5527       +4     
============================================
+ Hits          17711    17741      +30     
- Misses         7828     7850      +22     
  Partials       2243     2243              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…the error message should be based on whether it's due to a case insensitive match.
@lukedegruchy lukedegruchy changed the title Copy changes in 598-non-resolved-case-mismatch-warning into a fresh b… Use conditional logic to select the error message for an unmatched identifier based on whether it was a case-insensitive match Aug 27, 2024
@lukedegruchy lukedegruchy marked this pull request as ready for review August 27, 2024 21:03
@lukedegruchy lukedegruchy enabled auto-merge (squash) August 29, 2024 13:12
@lukedegruchy lukedegruchy disabled auto-merge August 29, 2024 13:24
@lukedegruchy lukedegruchy enabled auto-merge (squash) August 29, 2024 13:30
@lukedegruchy lukedegruchy merged commit 05c2bd3 into master Aug 30, 2024
5 checks passed
@lukedegruchy lukedegruchy deleted the 598-non-resolved-case-mismatch-warning-2 branch August 30, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "warning" when case-mismatching an identifier
4 participants