Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure per is set to something when visiting expand and collapse #1425

Merged
merged 6 commits into from
Nov 5, 2024

Conversation

antvaset
Copy link
Contributor

@antvaset antvaset commented Oct 20, 2024

Currently, the translator fails to build the call context for collapse { null } returning

Could not determine signature for invocation of operator System.Collapse.

This is because the per argument is not instantiated inside visitSetAggregateExpressionTerm when it's not explicitly set and source is not a list of intervals. In the case of collapse { null }, source is of type List<System.Any>. The fallback expression for per in all cases should be null of type System.Quantity.

I noticed this issue while working on #1424. collapse { null } still won't work due to a downstream error (which is being addressed in PR 1424):

Could not resolve call to operator Collapse with signature (list<System.Any>,System.Quantity).

Copy link

Formatting check succeeded!

Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.35%. Comparing base (8390d7a) to head (b816b4b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1425      +/-   ##
============================================
- Coverage     64.35%   64.35%   -0.01%     
- Complexity     1920     1921       +1     
============================================
  Files           494      494              
  Lines         28134    28131       -3     
  Branches       5588     5588              
============================================
- Hits          18106    18103       -3     
+ Misses         7776     7775       -1     
- Partials       2252     2253       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antvaset antvaset enabled auto-merge (squash) November 5, 2024 20:35
Copy link

sonarqubecloud bot commented Nov 5, 2024

@antvaset antvaset merged commit 3bdd109 into master Nov 5, 2024
6 checks passed
@antvaset antvaset deleted the set-per-in-expand-collapse branch November 5, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants