#1475: Fixed mapping expansions for profile-informed authoring not re… #1476
Conversation
…specting signature level
|
Formatting check succeeded! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1476 +/- ##
=========================================
Coverage 64.43% 64.44%
Complexity 1937 1937
=========================================
Files 494 494
Lines 28144 28154 +10
Branches 5588 5592 +4
=========================================
+ Hits 18135 18143 +8
- Misses 7754 7755 +1
- Partials 2255 2256 +1 ☔ View full report in Codecov by Sentry. |
| @@ -2743,6 +2743,22 @@ public Expression applyTargetMap(Expression source, String targetMap) { | |||
| String functionArgument = targetMap.substring(invocationStart + 1, targetMap.lastIndexOf(')')); | |||
| Expression argumentSource = | |||
| functionArgument.equals("%value") ? source : applyTargetMap(source, functionArgument); | |||
|
|
|||
| // NOTE: This is needed to work around the mapping for ToInterval | |||
There was a problem hiding this comment.
General feedback: Please fix the title and description of this PR so at a minimum it's not a truncated version of the commit message.
| @@ -467,4 +467,38 @@ void abstractClassNotRetrievable() throws IOException { | |||
| errors.stream().map(Throwable::getMessage).collect(Collectors.toList()); | |||
| assertThat(errorMessages, contains("Specified data type DomainResource does not support retrieval.")); | |||
| } | |||
|
|
|||
| @Test | |||
| void mappingExpansionsRespectSignatureLevel() throws IOException { | |||
There was a problem hiding this comment.
Please add a test for Signature.None to contrast with the test below. Also, it might be good to test other non-Overloads, non-None Signature types as well.
|
…specting signature level