Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1441: Fixes for Union #1480

Merged
merged 3 commits into from
Dec 19, 2024
Merged

#1441: Fixes for Union #1480

merged 3 commits into from
Dec 19, 2024

Conversation

JPercival
Copy link
Contributor

  • Fixed a bug where the fallback path for unions without result types was failing
  • Added more tests for unions
  • Engine still fails in cases where ambiguity exists when result types are absent, fixing that is a larger change in the engine.

@JPercival JPercival requested a review from brynrhodes December 18, 2024 22:02
Copy link

Formatting check succeeded!

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.44%. Comparing base (79b699a) to head (3b55270).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ds/cqf/cql/engine/execution/EvaluationVisitor.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1480   +/-   ##
=========================================
  Coverage     64.43%   64.44%           
- Complexity     1936     1937    +1     
=========================================
  Files           494      494           
  Lines         28154    28154           
  Branches       5592     5592           
=========================================
+ Hits          18142    18143    +1     
+ Misses         7756     7755    -1     
  Partials       2256     2256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JPercival JPercival merged commit 63b3bc4 into master Dec 19, 2024
6 of 7 checks passed
@JPercival JPercival deleted the bug-1441-union-results branch December 19, 2024 15:19
@JPercival JPercival changed the title Fixes for Union #1441: Fixes for Union Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants