Merge pull request #344 from DBCG/bug-fix-illegal-id-chars

Update illegal "_" chars in id to "-"
cqframework · Sep 15, 2021 · b494a9e · b494a9e
2 parents 11eeca6 + f89a257
commit b494a9e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/dstu3/src/main/java/org/opencds/cqf/dstu3/providers/MeasureOperationsProvider.java b/dstu3/src/main/java/org/opencds/cqf/dstu3/providers/MeasureOperationsProvider.java
@@ -277,7 +277,7 @@ public Parameters careGapsReport(@OperationParam(name = "periodStart") String pe
                         .setResource(patientCareGap(periodStart, periodEnd, subject, topic, measure, status)));
                 return returnParams;
             }else if(subject.startsWith("Group/")) {
-                returnParams.setId((status==null?"all-gaps": status) + "-" + subject.replace("/","_") + "-report");
+                returnParams.setId((status==null?"all-gaps": status) + "-" + subject.replace("/","-") + "-report");
                 (getPatientListFromGroup(subject))
                     .forEach(groupSubject ->{
                         Bundle patientGapBundle = patientCareGap(periodStart, periodEnd, groupSubject, topic, measure, status);
@@ -568,7 +568,8 @@ public Parameters report(@OperationParam(name = "periodStart", min = 1, max = 1)
         }    
         if (periodEnd == null) {
             throw new IllegalArgumentException("Parameter 'periodEnd' is required.");
-        }    Date periodStartDate = DateHelper.resolveRequestDate(periodStart, true);
+        }    
+        Date periodStartDate = DateHelper.resolveRequestDate(periodStart, true);
         Date periodEndDate = DateHelper.resolveRequestDate(periodEnd, false);
 
         if (periodStartDate.after(periodEndDate)) {
@@ -580,7 +581,7 @@ public Parameters report(@OperationParam(name = "periodStart", min = 1, max = 1)
         }
 
         Parameters returnParams = new Parameters();
-        returnParams.setId(subject.replace("/", "_") + "-report");
+        returnParams.setId(subject.replace("/", "-") + "-report");
 
         SearchParameterMap theParams = SearchParameterMap.newSynchronous();       
         (getPatientListFromSubject(subject))

diff --git a/r4/src/main/java/org/opencds/cqf/r4/providers/MeasureOperationsProvider.java b/r4/src/main/java/org/opencds/cqf/r4/providers/MeasureOperationsProvider.java
@@ -312,7 +312,7 @@ public Parameters careGapsReport(
             if (_subject.startsWith("Patient/")) {
                 resolvePatientGapBundleForMeasures(_periodStart, _periodEnd, _subject, topic, status, returnParams, measures, "return", organization);
             } else if (_subject.startsWith("Group/")) {
-                returnParams.setId(status + "-" + _subject.replace("/", "_") + "-report");
+                returnParams.setId(status + "-" + _subject.replace("/", "-") + "-report");
                 (getPatientListFromGroup(_subject))
                 .forEach(
                     groupSubject -> resolvePatientGapBundleForMeasures(
@@ -750,7 +750,7 @@ public Parameters report(@OperationParam(name = "periodStart", min = 1, max = 1)
         }
 
         Parameters returnParams = new Parameters();
-        returnParams.setId(subject.replace("/", "_") + "-report");
+        returnParams.setId(subject.replace("/", "-") + "-report");
 
         SearchParameterMap theParams = SearchParameterMap.newSynchronous();       
         (getPatientListFromSubject(subject))