Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address the test ignores #453

Closed
JPercival opened this issue Feb 10, 2022 · 1 comment
Closed

Address the test ignores #453

JPercival opened this issue Feb 10, 2022 · 1 comment
Assignees
@chalmarm
Labels
bug Something isn't working

Comments

@JPercival
Copy link
Contributor

JPercival commented Feb 10, 2022 •
edited
Loading

There are a few tests that are marked as "Ignored" due to various issues. We need to work through those and address whatever the underlying issue is. could be a badly written test or broken cqf-ruler functionality. Need to work through all the failing tests, figure out root cause for the failures, and add issues as required.
@JPercival JPercival added 3 bug Something isn't working labels Feb 10, 2022
@chalmarm
Copy link

chalmarm commented May 6, 2022

@JPercival Following are the places in cqf-ruler that gave me on grep for @ignore, am I looking at the right spot, seemed those are purposefully commented. Can you please point me to the right folder or place. Thanks,
ExampleServerR5IT.java
ElasticsearchLastNR4IT.java

JPercival added a commit that referenced this issue May 16, 2022
@JPercival
Merge pull request #513 from DBCG/bugs/address-ignore-disabled-tests
a15f0cd 
fixes #453, addressing to remove the disabled annotation to utilize the test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalmarm chalmarm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JPercival @chalmarm