Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cds-services not registering after commit b977daae5895e6f6c2fd89726284aab71e0a48c3 #575

Closed
mattStorer opened this issue Jul 27, 2022 · 6 comments
Assignees
Labels
bug Something isn't working cds-hooks Cds-hooks implementation

Comments

@mattStorer
Copy link

we've been using cqf-ruler on the master branch. we load FHIR resources into cqf-ruler that drive CDS Service operations. however, something recently broke this functionality.

I tracked the problem down to commit b977daa ("Fixed CDS Hooks service cache"), which appears to have something in it that breaks this functionality, insofar as after loading appropriate resources into CQF Ruler, this action no longer triggers the creation or representation of the associated CDS Services that are supposed to get created (i.e., "curl http://localhost:8080/cds-services" returns an empty array).

A commit from the previous day, f4c78a3 ("Fix bug in searching by version") restores the needed functionality, so we will be staying on this commit for our operations until this ticket is resolved.

Please let me know if you have any questions about any of the above.

Thanks!

@mattStorer
Copy link
Author

A commit from the previous day, f4c78a3 ("Fix bug in searching by version") restores the needed functionality, so we will be staying on this commit for our operations until this ticket is resolved.

Now that I think about it, this strategy is not going to be viable except in the very short term, as this build relies on SNAPSHOT dependencies, and over time these dependencies will cease to be compatible with this build of the ruler, which will likely force use to revert back to 0.4.1.

Eagerly awaiting the next tagged stable release -

@c-schuler
Copy link
Contributor

Hi @mattStorer! I just tested this locally by posting an artifact bundle with a PlanDefinition resource. It is updating the cache as expected and returning the service when calling the discovery endpoint. Note that the cache will remove services when the corresponding PlanDefinition is deleted. Would you mind sharing your artifact bundle or PlanDefinition so I can repro?

@c-schuler c-schuler self-assigned this Jul 27, 2022
@c-schuler
Copy link
Contributor

The issue is that the cache is cleared when restarting the server, requiring a clean build and re-upload of resources.

@c-schuler c-schuler added bug Something isn't working cds-hooks Cds-hooks implementation labels Jul 29, 2022
c-schuler added a commit that referenced this issue Jul 30, 2022
JPercival pushed a commit that referenced this issue Aug 1, 2022
#575: accounting for existing plandefinitions on when initializing cds hooks service cache
@c-schuler
Copy link
Contributor

@mattStorer please verify that PR #578 resolved this issue.

@aeyates
Copy link

aeyates commented Aug 3, 2022

@c-schuler and @mattStorer I pulled down the latest and confirmed that services now survive a restart without having to clean, package, and push resources again. Thanks!

@c-schuler
Copy link
Contributor

Thank you @aeyates !
Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cds-hooks Cds-hooks implementation
Projects
None yet
Development

No branches or pull requests

3 participants