GIC 3.0.0 merge #284
Merged
GIC 3.0.0 merge #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix name of parameter
Require status Return empty params if no result Fixed bug in gap detection
JPercival
requested changes
May 13, 2021
| String canonicalBase = urlsplit[0]; | ||
|
|
||
| String measureName = urlsplit[1]; | ||
| IdType measureIdType = new IdType(); |
There was a problem hiding this comment.
Here you actually need to do a lookup based on Measure name in order to get the Id.
There was a problem hiding this comment.
Added a TODO as this is a WIP (to be worked on at the ConnectConnectathon).
There was a problem hiding this comment.
Talked with Rob out of band, going to work on this in the upcoming connectathon
| @@ -587,7 +677,7 @@ else if (values.get(0) instanceof Reference | |||
| @SuppressWarnings("unchecked") | |||
| @Operation(name = "$submit-data", idempotent = true, type = Measure.class) | |||
| public Resource submitData(RequestDetails details, @IdParam IdType theId, | |||
| @OperationParam(name = "measurereport", min = 1, max = 1, type = MeasureReport.class) MeasureReport report, | |||
| @OperationParam(name = "measureReport", min = 1, max = 1, type = MeasureReport.class) MeasureReport report, | |||
JPercival
approved these changes
May 13, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.