Ensure the Patient resource type prefix in ProcedureRequest's subject… #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brynrhodes
reviewed
Jul 21, 2021
| procedureRequest.setSubject(new Reference(patientId)); | ||
| String patientReferenceString = patientId; | ||
| if (!patientId.startsWith("Patient/")) { | ||
| patientReferenceString = "Patient/" + patientId; |
There was a problem hiding this comment.
Reasonable, but what about if patientId is a contained reference? (e.g. #1234). And it should probably also account for the possibility that the reference is an absolute URL (e.g. http://blah-be-de-blah... and uuid:oid:XXX...)
There was a problem hiding this comment.
Used URI class to account for absoluteUrl and references to contained resources (indicated by presence of a fragment).
There was a problem hiding this comment.
Okay, but it does still need to check for the case that the input is relative, but already starts with Patient/
There was a problem hiding this comment.
Restored that check and also updated R4 with these same changes.
brynrhodes
approved these changes
Jul 21, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… reference.