Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature configurable cql logging #338

Merged
merged 5 commits into from
Sep 10, 2021
Merged

Feature configurable cql logging #338

merged 5 commits into from
Sep 10, 2021

Conversation

OHSUCMP
Copy link
Contributor

@OHSUCMP OHSUCMP commented Sep 9, 2021

contains updates to facilitate turning CQL debug logging on and off via a new 'cql.debugLogging.enabled' property in hapi.properties.

also added a logger config to logback.xml to turn DEBUG logging on for org.opencds.cqf.cql.engine.debug.DebugUtilities, the class that's responsible for writing CQL debug logs (this simplifies configuration by not requiring modifications to both hapi.properties and logback.xml when CQL debug logging is desired, now it only needs to be adjusted in one place).

@JPercival JPercival merged commit ee2dc6a into cqframework:master Sep 10, 2021
@JPercival
Copy link
Contributor

Hi Matt! Thanks so much for the contribution. This is something folks have asked for for a while. I merged your commits, and made a small change to the property name:

hapi.fhir.cql_logging_enabled=false

That naming pattern makes it slightly easier to promote to the upstream HAPI server since they have their own naming convention.

@JPercival
Copy link
Contributor

Documentation for the logging setting:

https://github.com/DBCG/cqf-ruler/wiki/Deployment#cql-logging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants