Feature ra plugin #392
Feature ra plugin #392
Conversation
| * @param start whether the date is the start of a period | ||
| * @return the FHIR period date as a java.util.Date type | ||
| */ | ||
| public default Date resolveRequestDate(String date, boolean start) { |
There was a problem hiding this comment.
This code already exists in the cql-evaluator
There was a problem hiding this comment.
I looked in the cql-evaluator and couldn't find it.
| * @param thePort the port to use | ||
| * @return String for the client url | ||
| */ | ||
| public default String getClientUrl(String theUrlTemplate, Integer thePort) { |
There was a problem hiding this comment.
This code isn't used anywhere?
There was a problem hiding this comment.
It's used in the ReportProviderIT. I thought it was going to be needed in non test classes too, but looks like that didn't pan out.
It could probably be moved to a test utilities.
There was a problem hiding this comment.
Moved to a test-utility plugin.
| dao.update(resource); | ||
| return (ResourceType) resource; | ||
| } | ||
| DaoRegistry theResourceDao, String theLocation, FhirContext theFhirContext) |
There was a problem hiding this comment.
Whoops. Meant to put this into a test utilities class.
There was a problem hiding this comment.
I went back and forth whether to put this in a test utilities or in this utility. I landed on "maybe a server would want to load from a location?"
There was a problem hiding this comment.
Moved to a test-utility plugin
Should we fix in the PR or merge and fix later? |
|
Moved the test utility bits to a test-utility plugin. It might not be perfect (like it feels like they should be excluded in a release build, etc.), but it should much closer. |
…eeded version specification in poms, adding .editorconfig, added application.yaml configuration
…into feature-ra-plugin
No description provided.