Updated cpg operations error reporting and cache management #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPercival
reviewed
Aug 9, 2022
| org.opencds.cqf.ruler.utility.dstu3.Parameters.newPart( | ||
| "error", (OperationOutcome) evaluationHelper.createIssue( | ||
| "invalid parameters", "prefetchData is not yet supported"))); | ||
| org.opencds.cqf.ruler.utility.dstu3.Parameters.newPart("invalid parameters", |
There was a problem hiding this comment.
try adding:
import static org.opencds.cqf.ruler.utility.dstu3.Parameters.newParameters
import static org.opencds.cqf.ruler.utility.dstu3.Parameters.newPart
then remove the namespacing from the functions. The idea behind the utility functions is that they improve readability. If they don't do that it doesn't serve much purpose.
JPercival
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning OperationOutcome when evaluation results in an exception
Removing library from cache before evaluation