Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Parameters utility for primitive types #613

Merged
merged 9 commits into from
Sep 26, 2022

Conversation

c-schuler
Copy link
Contributor

@c-schuler c-schuler commented Sep 21, 2022

Enhancement for #591

  • Added base generic Parameters class
  • Updated version-specific classes to use the logic from the base class (ensured that it is backwards compatible - non-breaking changes)
  • Added primitive type specific methods with the following pattern: newXPart where X is the primitive type name (e.g. newIntegerPart("integerPartExample", 42)) - unfortunately there were too many overlapping patterns to simply determine the type based on the raw type
  • Added tests for basic and new functionality

@c-schuler c-schuler requested a review from JPercival September 21, 2022 21:02
@JPercival
Copy link
Contributor

@c-schuler - Looks great! There are some conflicts with the master branch. Could you resolve those?

@JPercival JPercival merged commit 090edfc into master Sep 26, 2022
@JPercival JPercival deleted the #591-parameter-type-resolution branch September 26, 2022 21:37
@JPercival JPercival linked an issue Sep 26, 2022 that may be closed by this pull request
@JPercival JPercival linked an issue Sep 26, 2022 that may be closed by this pull request
@JPercival JPercival linked an issue Sep 26, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Parameters utility type resolution
2 participants