Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commit hash label and env variables to docker image #658

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Add commit hash label and env variables to docker image #658

merged 1 commit into from
Nov 3, 2022

Conversation

JPercival
Copy link
Contributor

@JPercival JPercival commented Nov 3, 2022 •
edited
Loading

Resolves #657

The commandline equivalent to the travis script is:

docker build . -t "$DOCKER_TAG" --build-arg COMMIT_HASH=$(git rev-parse HEAD)

@JPercival JPercival added the enhancement New feature or request label Nov 3, 2022
@JPercival JPercival requested a review from Capt-Mac November 3, 2022 15:48
@JPercival JPercival self-assigned this Nov 3, 2022
@JPercival JPercival merged commit bcb4719 into master Nov 3, 2022
@JPercival JPercival deleted the feature-tag-image-with-hash branch November 3, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Capt-Mac Capt-Mac Capt-Mac approved these changes

Assignees

@JPercival JPercival

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tag the generated Docker image with the commit hash that was used to generate it
2 participants
@JPercival @Capt-Mac