Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EuiButtonGroup for quick buttons #16

Merged
merged 4 commits into from
Jan 12, 2021

Conversation

andreadelrio
Copy link

@andreadelrio andreadelrio commented Jan 11, 2021

Summary

  • Added EuiButtonGroup for quick buttons.
  • In follow-up PR we can aim to build a reusable component for these buttons to reuse the existing code in Lens.

@cqliu1 there seem to be a few TS complaints, can you please take a look?

image 4

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cqliu1 cqliu1 merged commit 0f37597 into cqliu1:dashboard/embeddable-bar Jan 12, 2021
cqliu1 pushed a commit that referenced this pull request Apr 13, 2022
* [Unified search] Create unified search plugin

* add unified_search into USES_STYLED_COMPONENTS

* fix JEST group 4

* update limits for data plugin

* fix: remove unifiedSearch plugin from x-pack/plugins/file_upload

* feat: updated .github/CODEOWNERS and set @elastic/kibana-app-services as a code owner

* apply PR comments

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

* feat: moved filter bar, apply filters folders and apply filter action from Data plugin to unified search plugin

* fix Checks

* fix Checks

* fix Linting and Default CI Group #16

* fix Checks

* fix Checks

* fix Linting (with types)

* fix show FILTER_BAR

* fix Jest Tests

* feat replece indexPatternsContranct in setIndexPatterns to DataViewsContract

* feat: removed unnecessary interface in unified search

* fix Checks

* fix Checks

* fix Jest Tests, Checks

* fix Checks

* resolve comments

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cqliu1 pushed a commit that referenced this pull request Oct 5, 2023
elastic#167877)

Revert of elastic#164574

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Xavier Mouligneau <xavier.mouligneau@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants