Skip to content

Commit

Permalink
Hack: Add MetadataPushManager to AutoDJFeature for instantiation
Browse files Browse the repository at this point in the history
  • Loading branch information
cr7pt0gr4ph7 committed Oct 31, 2024
1 parent d7d6500 commit 447d515
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/library/autodj/autodjfeature.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <QtDebug>

#include "controllers/keyboard/keyboardeventfilter.h"
#include "integrations/metadatapushmanager.h"
#include "library/autodj/autodjprocessor.h"
#include "library/autodj/dlgautodj.h"
#include "library/dao/trackschema.h"
Expand Down Expand Up @@ -53,10 +54,12 @@ AutoDJFeature::AutoDJFeature(Library* pLibrary,
m_playlistDao(m_pTrackCollection->getPlaylistDAO()),
m_iAutoDJPlaylistId(findOrCrateAutoDjPlaylistId(m_playlistDao)),
m_pAutoDJProcessor(nullptr),
m_pMetadataPushManager(nullptr),

Check failure on line 57 in src/library/autodj/autodjfeature.cpp

View workflow job for this annotation

GitHub Actions / clazy

field 'm_pMetadataPushManager' will be initialized after field 'm_pSidebarModel' [-Werror,-Wreorder-ctor]

Check failure on line 57 in src/library/autodj/autodjfeature.cpp

View workflow job for this annotation

GitHub Actions / clang-tidy

field 'm_pMetadataPushManager' will be initialized after field 'm_pSidebarModel' [clang-diagnostic-reorder-ctor]

Check failure on line 57 in src/library/autodj/autodjfeature.cpp

View workflow job for this annotation

GitHub Actions / macOS 12 x64

field 'm_pMetadataPushManager' will be initialized after field 'm_pSidebarModel' [-Werror,-Wreorder-ctor]

Check failure on line 57 in src/library/autodj/autodjfeature.cpp

View workflow job for this annotation

GitHub Actions / macOS 12 arm64

field 'm_pMetadataPushManager' will be initialized after field 'm_pSidebarModel' [-Werror,-Wreorder-ctor]
m_pSidebarModel(make_parented<TreeItemModel>(this)),
m_pAutoDJView(nullptr),
m_autoDjCratesDao(m_iAutoDJPlaylistId, pLibrary->trackCollectionManager(), m_pConfig) {
qRegisterMetaType<AutoDJProcessor::AutoDJState>("AutoDJState");
m_pMetadataPushManager = new MetadataPushManager(this, m_pConfig, pPlayerManager);
m_pAutoDJProcessor = new AutoDJProcessor(this,
m_pConfig,
pPlayerManager,
Expand Down
2 changes: 2 additions & 0 deletions src/library/autodj/autodjfeature.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class WLibrarySidebar;
class QAction;
class QModelIndex;
class QPoint;
class MetadataPushManager;

class AutoDJFeature : public LibraryFeature {
Q_OBJECT
Expand Down Expand Up @@ -65,6 +66,7 @@ class AutoDJFeature : public LibraryFeature {
AutoDJProcessor* m_pAutoDJProcessor;
parented_ptr<TreeItemModel> m_pSidebarModel;

Check failure on line 67 in src/library/autodj/autodjfeature.h

View workflow job for this annotation

GitHub Actions / Ubuntu 22.04

‘parented_ptr<TreeItemModel> AutoDJFeature::m_pSidebarModel’ [-Werror=reorder]

Check warning on line 67 in src/library/autodj/autodjfeature.h

View workflow job for this annotation

GitHub Actions / coverage

‘parented_ptr<TreeItemModel> AutoDJFeature::m_pSidebarModel’ [-Wreorder]
DlgAutoDJ* m_pAutoDJView;
MetadataPushManager* m_pMetadataPushManager;

Check failure on line 69 in src/library/autodj/autodjfeature.h

View workflow job for this annotation

GitHub Actions / Ubuntu 22.04

‘AutoDJFeature::m_pMetadataPushManager’ will be initialized after [-Werror=reorder]

Check warning on line 69 in src/library/autodj/autodjfeature.h

View workflow job for this annotation

GitHub Actions / coverage

‘AutoDJFeature::m_pMetadataPushManager’ will be initialized after [-Wreorder]

// Initialize the list of crates loaded into the auto-DJ queue.
void constructCrateChildModel();
Expand Down

0 comments on commit 447d515

Please sign in to comment.