fixup! PlaylistStatsDAO: Consolidate into a single DAO instance

cr7pt0gr4ph7 · Apr 27, 2024 · 45b451f · 45b451f
1 parent 9244aee
commit 45b451f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/library/trackset/playlistfeature.cpp b/src/library/trackset/playlistfeature.cpp
@@ -124,7 +124,8 @@ QList<BasePlaylistFeature::IdAndLabel> PlaylistFeature::createPlaylistLabels() {
             m_pLibrary->trackCollectionManager()->internalCollection()->getPlaylistStatsDAO();
 
     QList<BasePlaylistFeature::IdAndLabel> playlistLabels;
-    for (auto playlistInfo : playlistStatsDao.getPlaylistSummaries(PlaylistDAO::PLHT_NOT_HIDDEN)) {
+    for (const auto& playlistInfo : playlistStatsDao.getPlaylistSummaries(
+                 PlaylistDAO::PLHT_NOT_HIDDEN)) {
         BasePlaylistFeature::IdAndLabel idAndLabel;
         idAndLabel.id = playlistInfo.playlistId;
         idAndLabel.label = createPlaylistLabel(

diff --git a/src/library/trackset/setlogfeature.cpp b/src/library/trackset/setlogfeature.cpp
@@ -240,7 +240,8 @@ QModelIndex SetlogFeature::constructChildModel(int selectedId) {
     // Generous estimate (number of years the db is used ;))
     itemList.reserve(kNumToplevelHistoryEntries + 15);
     int numEntries = 0;
-    for (auto playlistInfo : playlistStatsDao.getPlaylistSummaries(PlaylistDAO::PLHT_SET_LOG)) {
+    for (const auto& playlistInfo :
+            playlistStatsDao.getPlaylistSummaries(PlaylistDAO::PLHT_SET_LOG)) {
         int id = playlistInfo.playlistId;
         QString label = createPlaylistLabel(
                 playlistInfo.name, playlistInfo.count, playlistInfo.duration);