Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angles dependency #747

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Conversation

tonynajjar
Copy link
Contributor

Continuation of #739

tonynajjar and others added 4 commits April 26, 2022 11:50
* SHARED linking for Geographiclib (cra-ros-pkg#624) (cra-ros-pkg#713)

* remove GeographicLib specific linking option

Co-authored-by: Achmad Fathoni <fathoni.id@gmail.com>

* Fixing code style divergence for ament_uncrustify (cra-ros-pkg#742)

* Fixed state history reversion (cra-ros-pkg#736)

Co-authored-by: Zygfryd Wieszok <zwieszok@autonomous-systems.pl>

* Read predict_to_current_time from ROS parameters (cra-ros-pkg#737)

Co-authored-by: Zygfryd Wieszok <zwieszok@autonomous-systems.pl>

* Using angles library to normalize angles (cra-ros-pkg#739)

* Using angles library for innovation angle normalization

Co-authored-by: Stephan Sundermann <stephansundermann@gmail.com>
Co-authored-by: Achmad Fathoni <fathoni.id@gmail.com>
Co-authored-by: Anish <anishgdev@gmail.com>
Co-authored-by: Zygfryd Wieszok <zygfryd.wieszok@gmail.com>
Co-authored-by: Zygfryd Wieszok <zwieszok@autonomous-systems.pl>
Co-authored-by: Marek Piechula <marpiechula@gmail.com>
* SHARED linking for Geographiclib (cra-ros-pkg#624) (cra-ros-pkg#713)

* remove GeographicLib specific linking option

Co-authored-by: Achmad Fathoni <fathoni.id@gmail.com>

* Fixing code style divergence for ament_uncrustify (cra-ros-pkg#742)

* Fixed state history reversion (cra-ros-pkg#736)

Co-authored-by: Zygfryd Wieszok <zwieszok@autonomous-systems.pl>

* Read predict_to_current_time from ROS parameters (cra-ros-pkg#737)

Co-authored-by: Zygfryd Wieszok <zwieszok@autonomous-systems.pl>

* Using angles library to normalize angles (cra-ros-pkg#739)

* Using angles library for innovation angle normalization

Co-authored-by: Stephan Sundermann <stephansundermann@gmail.com>
Co-authored-by: Achmad Fathoni <fathoni.id@gmail.com>
Co-authored-by: Anish <anishgdev@gmail.com>
Co-authored-by: Zygfryd Wieszok <zygfryd.wieszok@gmail.com>
Co-authored-by: Zygfryd Wieszok <zwieszok@autonomous-systems.pl>
Co-authored-by: Marek Piechula <marpiechula@gmail.com>
@ayrton04
Copy link
Collaborator

Thanks!

@ayrton04 ayrton04 merged commit cf458bf into cra-ros-pkg:galactic Apr 26, 2022
@firemark
Copy link
Contributor

I think, this list of find_package invokes is not necessary - you probably should use ament_auto_find_build_dependencies() - this macro finds dependencies from package.xml and try to add in CmakeLists.txt

More info here: https://github.com/ament/ament_cmake/blob/master/ament_cmake_auto/cmake/ament_auto_find_build_dependencies.cmake

ayrton04 pushed a commit that referenced this pull request May 5, 2022
* Add angles to CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants