Update Make targets #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented in cracklib#87, the previous "make test" did not work under all circumstances including cross-compiling and out-of-source builds. This fixes those problems by making it a synonym for "make check" instead. Signed-off-by: Ed Beroset <beroset@ieee.org>
This removes the "dict" and "dict-local" targets and therefore also the "all-local" target that referred to them. This addresses cracklib#87 by removing targets that do not work under all circumstances, including cross-compiling and out-of-source builds. Signed-off-by: Ed Beroset <beroset@ieee.org>
This updates the README to instruct users to invoke create-cracklib-dict rather than using "make dict" which has been removed. Signed-off-by: Ed Beroset <beroset@ieee.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
dictanddict-localtargets because they are no longer needed and don't work under all circumstances, such as when cross-compiling or when building out-of-source. That, then, required updating the README to tell users to usecreate-cracklib-dictinstead and to remove theall-localtarget which just told the user to runmake dict. Finally, it also removes most ofmake testto make it simply a synonym formake check. This fixes #87.