Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lodash.template with template from lodash to avoid dependabot alerts #57

Closed
elrob opened this issue Apr 25, 2024 · 7 comments · Fixed by #62
Closed

Replace lodash.template with template from lodash to avoid dependabot alerts #57

elrob opened this issue Apr 25, 2024 · 7 comments · Fixed by #62

Comments

@elrob
Copy link

elrob commented Apr 25, 2024

lodash/lodash#5851

GHSA-35jh-r3h4-6jhm

Should be as simple as replacing the package to lodash or lodash-es and changing the import.

"lodash.template": "^4.5.0"

@craftamap
Copy link
Owner

Thanks @severian for fixing this in #59 :^)

@elrob
Copy link
Author

elrob commented May 13, 2024

Thank you!

@elrob
Copy link
Author

elrob commented May 13, 2024

@craftamap Are you able to publish a new release including the lodash dependency change?

@craftamap
Copy link
Owner

done, v0.7.0 got released:)

@elrob
Copy link
Author

elrob commented May 29, 2024

Thank you!

@jacwright
Copy link

jacwright commented Jun 12, 2024

0.7.0 is outputting the template tags in my HTML. Is anyone else seeing this?

Example output of my page:

<link.../>
<% if (process.env.NODE_ENV === 'production') { %>
<script>...</script>
<% } %>

turns into this:

<link.../>
&lt;% if (process.env.NODE_ENV === 'production') { %&gt;
<script>...</script>
&lt;% } %&gt;

0.6.1 works fine.

@craftamap craftamap reopened this Jun 13, 2024
@elrob
Copy link
Author

elrob commented Jun 13, 2024

I didn't see any issues but that's probably because I don't have any templating, just a static HTML snippet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants