allow copying of fields in matrix "block" but only when opened as a s…

…tandalone entry

src/helpers/ElementHelper.php

@@ -17,7 +17,6 @@
 use craft\db\Table;
 use craft\errors\OperationAbortedException;
 use craft\fieldlayoutelements\CustomField;
-use craft\fields\Matrix;
 use craft\i18n\Locale;
 use craft\services\ElementSources;
 use craft\web\View;
@@ -429,22 +428,13 @@ public static function isElementEditable(ElementInterface $element): bool
     /**
      * Returns whether given element supports having its field values copied from another site.
      *
-     * @param ElementInterface $element
+     * @param ElementInterface|null $element
      * @return bool
      */
     public static function supportsFieldCopying(?ElementInterface $element = null): bool
     {
-        // disallow copying fields in an entry that's nested in a matrix field,
-        // if the matrix field has view mode set to inline-editable blocks
-        if ($element instanceof NestedElementInterface) {
-            $field = $element->getField();
-
-            return !($field instanceof Matrix && $field->viewMode === Matrix::VIEW_MODE_BLOCKS);
-        }
-
         return !(!Craft::$app->getIsMultiSite() ||
             $element === null ||
-            //$element->getPrimaryOwnerId() ||
             count(static::editableSiteIdsForElement($element)) < 2);
     }
 

src/models/FieldLayout.php

@@ -823,6 +823,8 @@ public function createForm(?ElementInterface $element = null, bool $static = fal
         // Any already-included layout elements?
         $visibleElements = ArrayHelper::remove($config, 'visibleElements');
 
+        $disableCopying = ArrayHelper::remove($config, 'disableCopying') ?? false;
+
         $form = new FieldLayoutForm($config);
         $tabs = $this->getTabs();
 
@@ -877,6 +879,7 @@ public function createForm(?ElementInterface $element = null, bool $static = fal
                             $html = Html::modifyTagAttributes($html, [
                                 'data' => [
                                     'layout-element' => $isConditional ? $layoutElement->uid : true,
+                                    'disable-copying' => $disableCopying,
                                 ] + ($errorKey ? ['error-key' => $errorKey] : []),
                             ]);
 

src/templates/_components/fieldtypes/Matrix/block.twig

@@ -104,7 +104,10 @@
 {% endif %}
 
 {% namespace baseInputName %}
-  {% set form = entry.getFieldLayout().createForm(entry, static, {'errorKeyPrefix' : "#{name}[#{entry.uid}]"}) %}
+  {% set form = entry.getFieldLayout().createForm(entry, static, {
+    'errorKeyPrefix' : "#{name}[#{entry.uid}]",
+    'disableCopying': true,
+  }) %}
   {% set tabs = form.getTabMenu() %}
 {% endnamespace %}
 

src/web/assets/cp/src/js/CraftTooltip.js

@@ -1,4 +1,11 @@
-import {arrow, autoUpdate, computePosition, flip, offset, shift} from '@floating-ui/dom';
+import {
+  arrow,
+  autoUpdate,
+  computePosition,
+  flip,
+  offset,
+  shift,
+} from '@floating-ui/dom';
 
 /**
  * Tooltip

src/web/assets/cp/src/js/ElementEditor.js

@@ -678,6 +678,16 @@ Craft.ElementEditor = Garnish.Base.extend(
 
       const $btn = $(ev.currentTarget);
 
+      // don't show the hud if we're supposed to disable copying for this field
+      // this is used by fields inside inline-editable matrix "block"
+      const $fieldContainer = $btn.parents('.field');
+      if (
+        $fieldContainer.length > 0 &&
+        Garnish.hasAttr($fieldContainer[0], 'data-disable-copying')
+      ) {
+        return;
+      }
+
       const $hudContent = $('<div/>', {
         class: 'copy-translation-dialogue',
       });