Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x]: .menubtn breaks Command-click behavior #13550

Closed
timkelty opened this issue Aug 11, 2023 · 1 comment
Closed

[4.x]: .menubtn breaks Command-click behavior #13550

timkelty opened this issue Aug 11, 2023 · 1 comment
Assignees
@brandonkelly
Labels
bug craft4

Comments

@timkelty
Copy link
Contributor

timkelty commented Aug 11, 2023 •
edited by brandonkelly
Loading

What happened?

Description

  • New element on element index: Command-click in menu loads in a new window, but also loads in the current window
  • Create/save on element detail: Command-clicks don't open in a new window at all
  • Likely others? I didn't do a full sweep, but i'd guess this behavior exists on all .menubtns

Craft CMS version

4.5
@brandonkelly brandonkelly changed the title [4.x]: .menubtn breaks right click behavior [4.x]: .menubtn breaks Command-click behavior Aug 14, 2023
@brandonkelly brandonkelly self-assigned this Aug 14, 2023
brandonkelly added a commit that referenced this issue Aug 15, 2023
@brandonkelly
Fixed #13550
6699063
@brandonkelly
Copy link
Member

I was able to fix the first one. Save alternate actions need to stay on the current tab because there’s no way those can be normal links; they’re form-submits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandonkelly brandonkelly

Labels
bug craft4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timkelty @brandonkelly